feed2maildir: 3de30ccd7baa063c5775a357faaaa3a796238c3c
1: From: Billy Brumley <notifications@github.com>
2: Date: Fri, 23 Nov 2018 11:58:37 -0800
3: State: resolved
4: Subject: [Warbo/feed2maildir] RFC5322 date in email header. Better maildir
5: naming conformance. (#2)
6: Mime-Version: 1.0
7: Content-Type: multipart/alternative;
8: boundary="--==_mimepart_5bf85bed59464_3d133fb6898d45bc19371a";
9: charset=UTF-8
10: Content-Transfer-Encoding: 7bit
11: Message-Id: <99c47dba979cc8e0-0-artemis@nixos>
12: resolution: fixed
13:
14: ----==_mimepart_5bf85bed59464_3d133fb6898d45bc19371a
15: Content-Type: text/plain;
16: charset=UTF-8
17: Content-Transfer-Encoding: 7bit
18:
19: My email client (alpine) did not like the dates in these resulting emails.
20:
21: So the first thing I did was go check what the maildir files contained.
22:
23: Right off, and even before looking into the file contents, I noticed the maildir file names were not really consistent with the [maildir recommendation](https://cr.yp.to/proto/maildir.html). So I changed that.
24:
25: But it didn't fix it. Then looking at the file contents, the email date header wasn't [RFC complient](https://tools.ietf.org/html/rfc5322#section-3.3). So I changed that, and it fixed it.
26:
27: PS love the fork. Nice and modular :) Thanks!
28: You can view, comment on, or merge this pull request online at:
29:
30: https://github.com/Warbo/feed2maildir/pull/2
31:
32: -- Commit Summary --
33:
34: * [feed2maildir] RFC5322 date in email header. Better maildir naming conformance.
35:
36: -- File Changes --
37:
38: M feed2maildir/converter.py (11)
39:
40: -- Patch Links --
41:
42: https://github.com/Warbo/feed2maildir/pull/2.patch
43: https://github.com/Warbo/feed2maildir/pull/2.diff
44:
45: --
46: You are receiving this because you are subscribed to this thread.
47: Reply to this email directly or view it on GitHub:
48: https://github.com/Warbo/feed2maildir/pull/2
49:
50: ----==_mimepart_5bf85bed59464_3d133fb6898d45bc19371a
51: Content-Type: text/html;
52: charset=UTF-8
53: Content-Transfer-Encoding: 7bit
54:
55: <p>My email client (alpine) did not like the dates in these resulting emails.</p>
56: <p>So the first thing I did was go check what the maildir files contained.</p>
57: <p>Right off, and even before looking into the file contents, I noticed the maildir file names were not really consistent with the <a href="https://cr.yp.to/proto/maildir.html" rel="nofollow">maildir recommendation</a>. So I changed that.</p>
58: <p>But it didn't fix it. Then looking at the file contents, the email date header wasn't <a href="https://tools.ietf.org/html/rfc5322#section-3.3" rel="nofollow">RFC complient</a>. So I changed that, and it fixed it.</p>
59: <p>PS love the fork. Nice and modular :) Thanks!</p>
60:
61: <hr>
62:
63: <h4>You can view, comment on, or merge this pull request online at:</h4>
64: <p> <a href='https://github.com/Warbo/feed2maildir/pull/2'>https://github.com/Warbo/feed2maildir/pull/2</a></p>
65:
66: <h4>Commit Summary</h4>
67: <ul>
68: <li>[feed2maildir] RFC5322 date in email header. Better maildir naming conformance.</li>
69: </ul>
70:
71: <h4>File Changes</h4>
72: <ul>
73: <li>
74: <strong>M</strong>
75: <a href="https://github.com/Warbo/feed2maildir/pull/2/files#diff-0">feed2maildir/converter.py</a>
76: (11)
77: </li>
78: </ul>
79:
80: <h4>Patch Links:</h4>
81: <ul>
82: <li><a href='https://github.com/Warbo/feed2maildir/pull/2.patch'>https://github.com/Warbo/feed2maildir/pull/2.patch</a></li>
83: <li><a href='https://github.com/Warbo/feed2maildir/pull/2.diff'>https://github.com/Warbo/feed2maildir/pull/2.diff</a></li>
84: </ul>
85:
86: <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/Warbo/feed2maildir/pull/2">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AABtCWIQMBHqYbgpDAOwH3ApjwQ1-us1ks5uyFNtgaJpZM4YxFBd">mute the thread</a>.<img src="https://github.com/notifications/beacon/AABtCYOChEObu6ls00GhNO6MBm8cvGkDks5uyFNtgaJpZM4YxFBd.gif" height="1" width="1" alt="" /></p>
87: <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Warbo/feed2maildir","title":"Warbo/feed2maildir","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/Warbo/feed2maildir"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"RFC5322 date in email header. Better maildir naming conformance. (#2)"}],"action":{"name":"View Pull Request","url":"https://github.com/Warbo/feed2maildir/pull/2"}}}</script>
88: <script type="application/ld+json">[
89: {
90: "@context": "http://schema.org",
91: "@type": "EmailMessage",
92: "potentialAction": {
93: "@type": "ViewAction",
94: "target": "https://github.com/Warbo/feed2maildir/pull/2",
95: "url": "https://github.com/Warbo/feed2maildir/pull/2",
96: "name": "View Pull Request"
97: },
98: "description": "View this Pull Request on GitHub",
99: "publisher": {
100: "@type": "Organization",
101: "name": "GitHub",
102: "url": "https://github.com"
103: }
104: },
105: {
106: "@type": "MessageCard",
107: "@context": "http://schema.org/extensions",
108: "hideOriginalBody": "false",
109: "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
110: "title": "RFC5322 date in email header. Better maildir naming conformance. (#2)",
111: "sections": [
112: {
113: "text": "",
114: "activityTitle": "**Billy Brumley**",
115: "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
116: "activitySubtitle": "@bbbrumley",
117: "facts": [
118:
119: ]
120: },
121: {
122: "title": "Commit Summary",
123: "facts": [
124: {
125: "name": "ef162d6",
126: "value": "[feed2maildir] RFC5322 date in email header. Better maildir naming conformance."
127: }
128: ]
129: },
130: {
131: "title": "File Changes",
132: "facts": [
133: {
134: "name": "Modified",
135: "value": "[feed2maildir/converter.py](https://github.com/Warbo/feed2maildir/pull/2/files#diff-0) (11 changes)"
136: }
137: ]
138: }
139: ],
140: "potentialAction": [
141: {
142: "name": "Add a comment",
143: "@type": "ActionCard",
144: "inputs": [
145: {
146: "isMultiLine": true,
147: "@type": "TextInput",
148: "id": "IssueComment",
149: "isRequired": false
150: }
151: ],
152: "actions": [
153: {
154: "name": "Comment",
155: "@type": "HttpPOST",
156: "target": "https://api.github.com",
157: "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"Warbo/feed2maildir\",\n\"issueId\": 2,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
158: }
159: ]
160: },
161: {
162: "name": "Close pull request",
163: "@type": "HttpPOST",
164: "target": "https://api.github.com",
165: "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"Warbo/feed2maildir\",\n\"pullRequestId\": 2\n}"
166: },
167: {
168: "targets": [
169: {
170: "os": "default",
171: "uri": "https://github.com/Warbo/feed2maildir/pull/2"
172: }
173: ],
174: "@type": "OpenUri",
175: "name": "View on GitHub"
176: },
177: {
178: "targets": [
179: {
180: "os": "default",
181: "uri": "https://github.com/Warbo/feed2maildir/pull/2.patch"
182: }
183: ],
184: "@type": "OpenUri",
185: "name": "View patch"
186: },
187: {
188: "targets": [
189: {
190: "os": "default",
191: "uri": "https://github.com/Warbo/feed2maildir/pull/2.diff"
192: }
193: ],
194: "@type": "OpenUri",
195: "name": "View diff"
196: },
197: {
198: "name": "Unsubscribe",
199: "@type": "HttpPOST",
200: "target": "https://api.github.com",
201: "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 415518813\n}"
202: }
203: ],
204: "themeColor": "26292E"
205: }
206: ]</script>
207:
208: ----==_mimepart_5bf85bed59464_3d133fb6898d45bc19371a--
Generated by git2html.